Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access control policies #175

Merged
merged 46 commits into from
Dec 3, 2020
Merged

Access control policies #175

merged 46 commits into from
Dec 3, 2020

Conversation

coderGo93
Copy link
Contributor

@coderGo93 coderGo93 commented Oct 28, 2020 •
edited
Loading

Added Resource, datasource(s), tests, docs of Access Control Policies.

The acceptance tests has been passed.

Source: https://www.nutanix.dev/reference/prism_central/v3/api/access-control-policies/

@coderGo93 coderGo93 self-assigned this Oct 28, 2020
@coderGo93 coderGo93 changed the title WIP: Access control policies Access control policies Oct 30, 2020
@coderGo93 coderGo93 changed the base branch from master to v1.2.0 October 30, 2020 20:26
marinsalinas
marinsalinas suggested changes Oct 31, 2020
View reviewed changes
Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken a look into the Schema and I left some comments.

Also, can you address the linting error as well?

nutanix/resource_access_control_policy.go Outdated Show resolved Hide resolved
nutanix/resource_access_control_policy.go Outdated Show resolved Hide resolved
nutanix/resource_access_control_policy.go Outdated Show resolved Hide resolved
nutanix/resource_access_control_policy.go Outdated Show resolved Hide resolved
nutanix/resource_access_control_policy.go Outdated Show resolved Hide resolved
@yannickstruyf3
Copy link
Collaborator

@coderGo93 Can we rename the files so that they match the others:
resource_access_control_policy.go => resource_nutanix_access_control_policy.go
resource_access_control_policy_test.go => resource_nutanix_access_control_policy.go

@marinsalinas
Copy link
Contributor

@yannickstruyf3, next time, can you create another branch with your changes and make a PR against this branch in order to avoid conflicts if @coderGo93 is working on the same branch as well? I think this can avoid conflicts or unwanted changes.

Edgar López and others added 14 commits November 5, 2020 14:23
feat: added functions for access control policies in client
46642af
feat: added resource and datasource(s) for access control policies
28b52b7
fix: fixes linter make test
da7d8fc
fix: fixes and refactorized to make it work it the testacc
7aa598e
added validatefunc for some parameters
95a88e6
docs: added docs for access control policies
437dac5
refactor: refactorized and fixes linters
63769d9
updated docs
2a6a8e2
changed filter_context_list to context_filter_list
5935cfe
feat: renabled the projects resources and datasource(s)
4783c44
renamed files and hardcoded kind for project_reference
25d1eb0
@yannickstruyf3
added return nil in read function
331a899
@yannickstruyf3
modified code to support project and ACP use case. Also make sure tha…
eda63df 
…t subsequent applies return empty plan
@yannickstruyf3
removed api_version hardcoded
341af13
@yannickstruyf3
Copy link
Collaborator

@coderGo93 Modified the code for resource_domain to support maxItems 1 and to make it optional (in case no quotas are required)
#183

Edgar López and others added 22 commits November 17, 2020 11:37
@marinsalinas
fix: fixes linter make test
859a027
@marinsalinas
fix: fixes and refactorized to make it work it the testacc
5dc4da4
@marinsalinas
added validatefunc for some parameters
fc857ef
@marinsalinas
docs: added docs for access control policies
aeafde3
@marinsalinas
refactor: refactorized and fixes linters
e1de2e9
@marinsalinas
updated docs
b3488fa
@marinsalinas
changed filter_context_list to context_filter_list
5ead910
@marinsalinas
feat: renabled the projects resources and datasource(s)
e0226b2
@marinsalinas
renamed files and hardcoded kind for project_reference
0a14a51
@yannickstruyf3 @marinsalinas
added return nil in read function
0570d0d
@yannickstruyf3 @marinsalinas
modified code to support project and ACP use case. Also make sure tha…
fae5cf3 
…t subsequent applies return empty plan
@yannickstruyf3 @marinsalinas
removed api_version hardcoded
5db9c7d
@marinsalinas
chore: updated vendor
eaed354
@marinsalinas
updated imports
961a3cf
@marinsalinas
refactorized some mistakes
7982f48
@yannickstruyf3 @marinsalinas
made resource_domain optional -> quotas are also optional in projects
392a410
@yannickstruyf3 @marinsalinas
added max items to resource_domain
5ddab05
@marinsalinas
Merge pull request #185 from nutanix/acp-update
ee6ca52 
Update ACP from master
@yannickstruyf3
modified typeset casting for user_reference_list and user_group_refer…
c80218f 
…ence_list
@marinsalinas
Merge pull request #187 from yannickstruyf3/acp_update_typeset
f86555c 
Acp update typeset
@yannickstruyf3
fix wwrong assignment of userreferencelist
370943b
@marinsalinas
Merge pull request #189 from yannickstruyf3/bugfix/acp-update-user-re…
19ba3e3 
…ference-list-branch-2

fix wwrong assignment of userreferencelist
@marinsalinas marinsalinas changed the base branch from v1.2.0 to v1.2.0-beta December 3, 2020 15:39
@marinsalinas marinsalinas merged commit a6a8e50 into v1.2.0-beta Dec 3, 2020
@marinsalinas marinsalinas deleted the access-policies branch December 3, 2020 21:49
yannickstruyf3 pushed a commit to yannickstruyf3/terraform-provider-nutanix that referenced this pull request Nov 9, 2021
@marinsalinas
Merge pull request nutanix#175 from nutanix/access-policies
3e56cf2 
Access control policies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marinsalinas marinsalinas marinsalinas approved these changes

Assignees

@coderGo93 coderGo93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coderGo93 @yannickstruyf3 @marinsalinas